Skip to content

Fixed typing in 'import_classes_from_module' function #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab295382 merged 2 commits into from
Aug 18, 2026
Merged

Fixed typing in 'import_classes_from_module' function #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4077910
Lightly refactored 'import_classes_from_module' function to fix typin…
gchqdev227 Aug 17, 2026
e230d54
Fixed missing try/except block
gchqdev227 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions concoursetools/importing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,20 @@ def import_classes_from_module(file_path: Path, parent_class: type[T]) -> dict[s
import_path = file_path_to_import_path(file_path)
module = import_py_file(import_path, file_path)

possible_resource_classes = {}
possible_resource_classes: dict[str, type[T]] = {}
for _, cls in inspect.getmembers(module, predicate=inspect.isclass):

try:
class_is_subclass_of_parent = issubclass(cls, parent_class)
if not issubclass(cls, parent_class):
continue
except TypeError:
class_is_subclass_of_parent = False
# This can fail in Python 3.10
continue

class_is_defined_in_this_module = (cls.__module__ == import_path)
class_is_not_private = (not cls.__name__.startswith("_"))

if class_is_subclass_of_parent and class_is_defined_in_this_module and class_is_not_private:
if class_is_defined_in_this_module and class_is_not_private:
possible_resource_classes[cls.__name__] = cls

return possible_resource_classes
Expand Down