Skip to content

fix: ellipsis on long masked values #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gchiesa merged 1 commit into from
Jul 18, 2026
Merged

fix: ellipsis on long masked values #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/api/handlers_blocklist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import (

const (
// headerMarker separates the URI path from the optional header list in the URL.
headerMarker = "/_headers/"
headerMarker = "/_headers/"
maxMaskedChars = 10
)

// parseEntityFromWildcard splits the Fiber wildcard parameter (everything after
Expand Down Expand Up @@ -144,9 +145,16 @@ func maskHeader(headerValue string, expr *regexp.Regexp) string {
return headerValue
}
g1Start, g1End := locs[2], locs[3]
// if the masked portion is > 10 chars, then we cut it and add `...`
threeDots := ""
endRepeat := len(headerValue) - g1End
if endRepeat > maxMaskedChars {
endRepeat = maxMaskedChars
threeDots = "..."
}
return strings.Repeat("*", g1Start) +
headerValue[g1Start:g1End] +
strings.Repeat("*", len(headerValue)-g1End)
strings.Repeat("*", endRepeat) + threeDots
}

// handleBlockEntityAdd handles POST /v1/blocked-entity/:ip/_path/*.
Expand Down
6 changes: 3 additions & 3 deletions internal/api/handlers_blocklist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,14 +518,14 @@ func TestMaskHeader_ApiKeyPattern(t *testing.T) {
// Typical use-case from the docs: show first 3 chars, mask the rest.
expr := regexp.MustCompile(`^(.{0,3}).*$`)
got := maskHeader("sk_live_xyz9876", expr)
assert.Equal(t, "sk_************", got)
assert.Equal(t, "sk_**********...", got)
}

func TestMaskHeader_BearerToken(t *testing.T) {
expr := regexp.MustCompile(`^(Bearer .{0,3}).*$`)
got := maskHeader("Bearer sk_test_abc123", expr)
// "Bearer sk" (9 chars kept) + 11 stars
assert.Equal(t, "Bearer sk_***********", got)
assert.Equal(t, "Bearer sk_**********...", got)
}

func TestMaskHeader_NoMatch_ReturnsOriginal(t *testing.T) {
Expand Down Expand Up @@ -597,7 +597,7 @@ func TestBlockEntityList_HeaderRedactionApplied(t *testing.T) {
require.Len(t, entries, 1)

got := entries[0].Headers["X-Api-Key"]
assert.Equal(t, "abc************", got, "first 3 chars kept, rest masked")
assert.Equal(t, "abc**********...", got, "first 3 chars kept, rest masked")
}

func TestBlockEntityList_UnredactedHeadersPassThrough(t *testing.T) {
Expand Down
Loading