Skip to content

Prevent then from being called after end #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jleider wants to merge 2 commits into
base: master
Choose a base branch
from
+36 −355
Open

Prevent then from being called after end #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ee222
Prevent `then` from being called after `end`
jleider Jun 7, 2022
d6bbc55
Merge branch 'master' into no-then-after-end
StefanoMagrassi Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
**Note**: Gaps between patch versions are faulty/broken releases. **Note**: A feature tagged as Experimental is in a
high state of flux, you're at risk of it changing without notice.

# 0.6.0

@StefanoMagrassi StefanoMagrassi Jun 15, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleider we will bump the package's version and add the entry in the changelog just before publish the v0.6.0


- **Breaking Change**
- Prevent `then` from being called after `end` (@jleider)

# 0.5.4

- **Polish**
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ const notFound: Location = { _tag: 'NotFound' }

// matches
const defaults = end
const homeMatch = lit('home').then(end)
const homeMatch = lit('home').end()
const userIdMatch = lit('users').then(int('userId'))
const userMatch = userIdMatch.then(end)
const userMatch = userIdMatch.end()
const invoiceMatch = userIdMatch
.then(lit('invoice'))
.then(int('invoiceId'))
.then(end)
.end()

// router
const router = zero<Location>()
Expand Down
Loading