Skip to content

Removed prop-type issues and unused imports - #95

Merged
LOGESH-B merged 2 commits into
gbowne1:masterfrom
neeravbhaskarla:bugfix-fixedissue92and91
Jul 25, 2023
Merged

Removed prop-type issues and unused imports#95
LOGESH-B merged 2 commits into
gbowne1:masterfrom
neeravbhaskarla:bugfix-fixedissue92and91

Conversation

@neeravbhaskarla

@neeravbhaskarla neeravbhaskarla commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Fixes issue: #91 and #92

@neeravbhaskarla
neeravbhaskarla requested a review from gbowne1 as a code owner July 25, 2023 10:27
@gbowne1
gbowne1 requested a review from LOGESH-B July 25, 2023 14:43
@gbowne1 gbowne1 added the bug Something isn't working label Jul 25, 2023
gbowne1
gbowne1 requested changes Jul 25, 2023
View reviewed changes

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login now has merge conflicts from Login.jsx merging @LOGESH-B's PR

I checked out this change locally for testing and review. This does include adding necessary prop types and the prop types imports but might need a little more work after merging

Other than that this looks good and can be merged following fixing conflicts

@neeravbhaskarla @LOGESH-B

@neeravbhaskarla

neeravbhaskarla commented Jul 25, 2023

Copy link
Copy Markdown
Contributor Author

Login now has merge conflicts from Login.jsx merging @LOGESH-B's PR

I checked out this change locally for testing and review. This does include adding necessary prop types and the prop types imports but might need a little more work after merging

Other than that this looks good and can be merged following fixing conflicts

@neeravbhaskarla @LOGESH-B

will commit with the updated changes

@gbowne1

gbowne1 commented Jul 25, 2023

Copy link
Copy Markdown
Owner

Thanks

@neeravbhaskarla
neeravbhaskarla requested a review from gbowne1 July 25, 2023 15:13
This was linked to issues Jul 25, 2023
[TODO][BUG] Remove unused imports from the codebase #91
Closed
[TODO][BUG] Fix the prop-types issues #92
Closed
gbowne1
gbowne1 approved these changes Jul 25, 2023
View reviewed changes

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes appear to resolve merge conflicts.

Approving for merge

LOGESH-B
LOGESH-B approved these changes Jul 25, 2023
View reviewed changes

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @neeravbhaskarla
Thanks for your contribution🙌
Tested Locally and Approving for merge

@LOGESH-B
LOGESH-B merged commit 8a02f79 into gbowne1:master Jul 25, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbowne1 gbowne1 gbowne1 approved these changes
@LOGESH-B LOGESH-B LOGESH-B approved these changes

Assignees

@neeravbhaskarla neeravbhaskarla

Labels

bug Something isn't working

Projects

CodeBooker
Status: Done

Milestone

Frontend

Development

Successfully merging this pull request may close these issues.

[TODO][BUG] Fix the prop-types issues [TODO][BUG] Remove unused imports from the codebase

3 participants

@neeravbhaskarla @gbowne1 @LOGESH-B