Skip to content

Sidebar added using <Drawer /> from MUI v5.11.6 - #9

Merged
gbowne1 merged 1 commit into
gbowne1:masterfrom
Yuva0:SideDrawerAdded
Apr 14, 2023
Merged

Sidebar added using <Drawer /> from MUI v5.11.6#9
gbowne1 merged 1 commit into
gbowne1:masterfrom
Yuva0:SideDrawerAdded

Conversation

@Yuva0

@Yuva0 Yuva0 commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Description

image

Sidebar with collapsible sub-items has been added to the project.

Fixes # (issue)
Add a 200-250px Sidebar using from MUI v5.11.6 #3
#3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist

  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [ X ] I have checked my code and corrected any misspellings

@Yuva0
Yuva0 requested a review from gbowne1 as a code owner April 14, 2023 13:07

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out this change and tested locally as the first iteration of the SideNav/Sidebar.

It seems to look and work as described.

Thanks for the opportunity to review your PR, @Yuva0

@gbowne1 gbowne1 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 14, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Apr 14, 2023
@gbowne1 gbowne1 linked an issue Apr 14, 2023 that may be closed by this pull request
@gbowne1
gbowne1 merged commit b942c9d into gbowne1:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[TODO] Add a 200-250px Sidebar using <Drawer /> from MUI v5.11.6

2 participants