Skip to content

added books table sorting feature #40 - #45

Merged
gbowne1 merged 1 commit into
gbowne1:masterfrom
Vishwanath760970:sorting-books-table#40
Jun 9, 2023
Merged

added books table sorting feature #40#45
gbowne1 merged 1 commit into
gbowne1:masterfrom
Vishwanath760970:sorting-books-table#40

Conversation

@Vishwanath760970

Copy link
Copy Markdown
Contributor

@gbowne1 I have implemented the books table sorting feature, for all the columns.

Refer below gif for fix working in my local.

codebooker issue 3 #40

It seems the table pagination feature implementation, has some complexities in implementing and needs more time, so I will take it up by creating another separate issue in coming days.

But with respect to this PR, please review and merge it.

@Vishwanath760970
Vishwanath760970 requested a review from gbowne1 as a code owner June 9, 2023 18:25

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out this change locally for testing.

This change appears to work as the PR shows.

Approving for merge.

Keep in mind that this view is the users own library. All of these entries would get added to the global database if the book was not foumd. Furthermore, book reviews would get added to global scope as well.

We need to implement the main part of the app which would show everyones added books and reviews.

Not sure how to best go about this.

@gbowne1
gbowne1 merged commit 1574b6f into gbowne1:master Jun 9, 2023
@gbowne1 gbowne1 linked an issue Jun 9, 2023 that may be closed by this pull request
@Vishwanath760970

Copy link
Copy Markdown
Contributor Author

Checked out this change locally for testing.

This change appears to work as the PR shows.

Approving for merge.

Keep in mind that this view is the users own library. All of these entries would get added to the global database if the book was not foumd. Furthermore, book reviews would get added to global scope as well.

We need to implement the main part of the app which would show everyones added books and reviews.

Not sure how to best go about this.

We need to implement the logic for user account creation and have views for current user dashboard,
and a separate dashboard for global books dashboard.
the logged in user can add books to global dashboard and mark a book as his favorite to his account collection.
For this we need to implement the backend logic with database.
and also some application routes using a routing library, to display different screens as global dashboard and, specific user dashboard.

@gbowne1

gbowne1 commented Jun 10, 2023

Copy link
Copy Markdown
Owner

@Vishwanath760970 yes we should. Theres no user land stuff done yet. New issue time?

@gbowne1 gbowne1 added this to the Frontend milestone Jun 10, 2023
@Vishwanath760970

Copy link
Copy Markdown
Contributor Author

@Vishwanath760970 yes we should. Theres no user land stuff done yet. New issue time?

Yeah, there's nothing done yet for creating new users or users landing page, guess you need to create a new issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add a way to sort the users library table

2 participants