added books table sorting feature #40 - #45
Conversation
gbowne1
left a comment
There was a problem hiding this comment.
Checked out this change locally for testing.
This change appears to work as the PR shows.
Approving for merge.
Keep in mind that this view is the users own library. All of these entries would get added to the global database if the book was not foumd. Furthermore, book reviews would get added to global scope as well.
We need to implement the main part of the app which would show everyones added books and reviews.
Not sure how to best go about this.
We need to implement the logic for user account creation and have views for current user dashboard, |
|
@Vishwanath760970 yes we should. Theres no user land stuff done yet. New issue time? |
Yeah, there's nothing done yet for creating new users or users landing page, guess you need to create a new issue for it. |
@gbowne1 I have implemented the books table sorting feature, for all the columns.
Refer below gif for fix working in my local.
It seems the table pagination feature implementation, has some complexities in implementing and needs more time, so I will take it up by creating another separate issue in coming days.
But with respect to this PR, please review and merge it.