fixes #220 added empty depedency in useEffect - #227
Merged
Conversation
This was
linked to
issues
Oct 6, 2024
Owner
|
We have tried to fix this issue before @love-sonkar. |
gbowne1
approved these changes
Oct 6, 2024
gbowne1
left a comment
gbowne1
left a comment
Owner
There was a problem hiding this comment.
This PR fixes the infinite fetching loop by adding a empty dependency array
We have tried fixing this issue before.
Library.jsx is a huge file and really needs broken down into other things.
Approving this PR for merge
Thanks for the opportunity to review your PR and for your contribution
gbowne1
assigned
LOGESH-B,
BlackBond06 and
love-sonkar and unassigned
LOGESH-B and
BlackBond06
gbowne1
added
bug
LOGESH-B
approved these changes
Oct 8, 2024
LOGESH-B
left a comment
LOGESH-B
left a comment
Collaborator
There was a problem hiding this comment.
Adding empty array prevents the infinite call of the fetchBooksFromDB()
BlackBond06
approved these changes
Oct 12, 2024
BlackBond06
left a comment
BlackBond06
left a comment
Collaborator
There was a problem hiding this comment.
Changes in this PR works as expected, without any bugs. This effectively stops the continuing rendering of fetched books.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixedd #220
i have added an empty depedency array in useEffect to stop infinite loop fetching issue.