Fix: Home.jsx and Library.jsx useEffect hook missing dependency issue - #177
Merged
Conversation
Piyush-Deshmukh
changed the title
Home.jsx and Library.jsx useEffect hook issueHome.jsx and Library.jsx useEffect hook missing dependency issue
gbowne1
added
bug
LOGESH-B
approved these changes
Sep 16, 2023
LOGESH-B
left a comment
LOGESH-B
left a comment
Collaborator
There was a problem hiding this comment.
Hii @Piyush-Deshmukh
Thanks for your contribution✌️
Tested Locally.Removes the warning at home.jsx and library.jsx
Approving for merge
gbowne1
approved these changes
Sep 16, 2023
gbowne1
left a comment
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- Checked out this change locally for testing and review for merging
- Manually reviewed this change for syntax and other errors
Looks like this change works as expected, fixing the missing dependency for the useEffect hook. There are no more warnings about this in the console, etc.
Approving for merge. Thank you for the opportunity to review your PR for merging @Piyush-Deshmukh
BlackBond06
approved these changes
Sep 16, 2023
BlackBond06
left a comment
BlackBond06
left a comment
Collaborator
There was a problem hiding this comment.
Tested change locally. This PR fixes the useEffect missing dependency warning. Approving for merge. Thank you for the opportunity to review your PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174
Modified Files
Modifications
Home.jsxadded missing dependencylocation.stateLibrary.jsxadded missing dependencysetFilter