Skip to content

Feat/add tailwindcss on top of mui - #173

Merged
gbowne1 merged 7 commits into
gbowne1:masterfrom
BlackBond06:Feat/Add-tailwind-on-top-of-mui
Sep 14, 2023
Merged

Feat/add tailwindcss on top of mui#173
gbowne1 merged 7 commits into
gbowne1:masterfrom
BlackBond06:Feat/Add-tailwind-on-top-of-mui

Conversation

@BlackBond06

Copy link
Copy Markdown
Collaborator

This PR introduces the integration of TailwindCSS alongside Material-UI version 5 (MUI v5) in our project.

Changes Made

  • Added TailwindCSS as a CSS utility framework.
  • Removed nested styles from BookSearch.css to address Tailwind nesting style error.

@gbowne1 gbowne1 assigned LOGESH-B and BlackBond06 and unassigned LOGESH-B Sep 12, 2023
@gbowne1
gbowne1 requested a review from LOGESH-B September 12, 2023 18:43

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out this change locally for testing for review and merg
  • Manuallly reviewed browser console for errors and warnings
  • Manually reviewed for spelling, grammar and syntax errors.

This change adds Tailwind CSS to improve and enhance the MUI styling we are already using. It does not appear to add any additional errors or warnings to the app. It will improve our styling greatly.

Approving for merge

@gbowne1 gbowne1 added enhancement New feature or request frontend Work on Frontend usability This is related to UX or usability code-review This is ready for code review needs-review This issue, discussion or PR needs review labels Sep 12, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Sep 12, 2023
@gbowne1 gbowne1 linked an issue Sep 12, 2023 that may be closed by this pull request

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @BlackBond06
Thank you for the oppotunity to review your PR for merging
This code not producing any error but I got one warning.Is anybody getting this?

image

@BlackBond06

Copy link
Copy Markdown
Collaborator Author

No I did not get that error. But I'll look into it. Has the issue been merged?

@gbowne1

gbowne1 commented Sep 13, 2023

Copy link
Copy Markdown
Owner

Not been merged yet.

Edit: I didnt get that either.

@gbowne1

gbowne1 commented Sep 13, 2023

Copy link
Copy Markdown
Owner

I merged the other two PR's, sync and see what is working now.

@BlackBond06

Copy link
Copy Markdown
Collaborator Author

@LOGESH-B, I still dont get the error. can you make a video so I know where it is coming from ?

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @BlackBond06
The error is now resolved...I don't know where it araises from...
Approving for merge🙌

@gbowne1
gbowne1 merged commit dc1c044 into gbowne1:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-review This is ready for code review enhancement New feature or request frontend Work on Frontend needs-review This issue, discussion or PR needs review usability This is related to UX or usability

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEAT][TODO] Add TailwindCSS on top of MUI v5

3 participants