Skip to content

Feature/capture feedback - #169

Merged
gbowne1 merged 47 commits into
gbowne1:masterfrom
vktr-r2:feature/capture-feedback
Sep 12, 2023
Merged

Feature/capture feedback#169
gbowne1 merged 47 commits into
gbowne1:masterfrom
vktr-r2:feature/capture-feedback

Conversation

@vktr-r2

@vktr-r2 vktr-r2 commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

vktr-r2 added 30 commits August 30, 2023 18:28
@vktr-r2
Setup CaptureFeedback component and styling files
1640af2
@vktr-r2
Add state management to component
6fe0a33
@vktr-r2
Add styling to CaptureFeedback panel
c5dc75e
@vktr-r2
Update panel width
7cb12b8
@vktr-r2
Update CaptureFeedback state management and pass props
ca1224c
@vktr-r2
Update styling
b1bceaf
@vktr-r2
Convert panel to modal
6a82a0d
@vktr-r2
Add Formik form to modal
048c51c
@vktr-r2
Update modal to prompt user with two feedback flows
f5c860b
@vktr-r2
Add star rating functionality
f61c78b
@vktr-r2
Update forms styling
6ce5647
@vktr-r2
Add comments
0f43ca3
@vktr-r2
Add fetch POST to onSubmit function
7deb718
@vktr-r2
Add handle response and errorpromise chain
28795d9
@vktr-r2
Update Yup direct feedback validation
7a9df00
@vktr-r2
Add error handling for response
ef858fc
@vktr-r2
Update inital values for feedback rating
41904f9
@vktr-r2
Add login session validation to userRoutes
bde4e27
@vktr-r2
Update feedbackController to pull userId from current session
14f928e
@vktr-r2
Add code to save userId in session for feedback submission
2330edc
@vktr-r2
Update form validation to allow for initial rating
d91be93
@vktr-r2
Add proxy
af2aa2b
@vktr-r2
Remove session authentication check
dbd8cc2
@vktr-r2
Refactor addfeedback func to receive author from req.body
0fee8d5
@vktr-r2
Refactor onSubmit to obtain user/token from localStorage
233dd8b
@vktr-r2
Add setFieldValue to Rating component to update state
897c8c6
@vktr-r2
Add feedback/mail route
fc1f05d
@vktr-r2
Implement emailFeedback controller function
96c167c
@vktr-r2
Update state management for Rating component
1befb0a
@vktr-r2
Implement env vars
ef5b2f0
@vktr-r2
vktr-r2 requested a review from gbowne1 as a code owner September 11, 2023 21:37
@gbowne1 gbowne1 added enhancement New feature or request frontend Work on Frontend feature request this is a feature request code-review This is ready for code review needs-review This issue, discussion or PR needs review labels Sep 11, 2023
@gbowne1 gbowne1 linked an issue Sep 11, 2023 that may be closed by this pull request
[FEAT] Add a Feedback panel #124
Closed
@gbowne1 gbowne1 added this to the Frontend milestone Sep 11, 2023
gbowne1
gbowne1 approved these changes Sep 11, 2023
View reviewed changes

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out this change locally for testing and review for merging
  • Manually reviewed the new features in browser for new errors/warnings
  • Manually reviewed the code for spelling and other syntax issues

This PR change implements a Feedback feature to capture user feedback.

It does not appear to add any additional warnings or errors.

Approving for merge. Thank you for the opportunity to review your PR!

LOGESH-B
LOGESH-B approved these changes Sep 12, 2023
View reviewed changes

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @vktr-r2
Tested Locally Approving for Merge
Thanks for you Cotriibution🙌

@BlackBond06

BlackBond06 commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

Hi @vktr-r2
Tested changes locally, approved for merging.
Thank you for the opportunity to review your PR!

@gbowne1

gbowne1 commented Sep 12, 2023

Copy link
Copy Markdown
Owner

@BlackBond06 Use the green Review button at the top of the PR to submit your review. You will get a popup to review the PR, with options to comment, request changes or approve.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

@gbowne1

gbowne1 commented Sep 12, 2023

Copy link
Copy Markdown
Owner

@victor20m In the future, please enter a description of your changes in the desciption box of the PR.

Merging this PR.

Thanks for your contribution!

@gbowne1
gbowne1 merged commit 06939a5 into gbowne1:master Sep 12, 2023
@BlackBond06

BlackBond06 commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

@gbowne1 I still need to add a comment after I have approved the changes ?

@gbowne1

gbowne1 commented Sep 12, 2023

Copy link
Copy Markdown
Owner

no, it may not have picked up that. But I looked and I see it did now. thanks @BlackBond06

@gbowne1 gbowne1 mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbowne1 gbowne1 gbowne1 approved these changes
@LOGESH-B LOGESH-B LOGESH-B approved these changes
@BlackBond06 BlackBond06 BlackBond06 approved these changes

Assignees

@vktr-r2 vktr-r2

Labels

code-review This is ready for code review enhancement New feature or request feature request this is a feature request frontend Work on Frontend needs-review This issue, discussion or PR needs review

Projects

CodeBooker
Status: Done

Milestone

Frontend

Development

Successfully merging this pull request may close these issues.

[FEAT] Add a Feedback panel

4 participants

@vktr-r2 @BlackBond06 @gbowne1 @LOGESH-B