Bug/fix library jsx use effect issues - #161
Merged
LOGESH-B merged 3 commits intoSep 1, 2023
Merged
Conversation
gbowne1
approved these changes
Aug 31, 2023
gbowne1
left a comment
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- Checked out this change locally for testing and review
- Manually reviewed browser console for errors/warnings
This change does appear to fix the useEffect issue #161 and this change also does not appear to cause additional errors.
Thank you for the opportunity to review your PR for merging.
Approving for merge. Looking forwards to seeing some working tests with Jest, etc.
LOGESH-B
approved these changes
Sep 1, 2023
LOGESH-B
left a comment
LOGESH-B
left a comment
Collaborator
There was a problem hiding this comment.
Hii @BlackBond06
Thanks for your contribution
Approving for merge🙌
Owner
|
@BlackBond06 That was your 5th successful merge. I sent you a Collaborator invite. Thanks so much for all of your great contributions. Welcome aboard. |
Collaborator
|
Welcome buddy @BlackBond06 🤝🙌 |
Collaborator
Author
Owner
|
You're welcome! @BlackBond06 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #160 opened by @gbowne1.
Changes Made: