Skip to content

feature: added privacy-policy page - #153

Merged
LOGESH-B merged 1 commit into
gbowne1:masterfrom
alienqqe:privacy-policy
Aug 30, 2023
Merged

feature: added privacy-policy page#153
LOGESH-B merged 1 commit into
gbowne1:masterfrom
alienqqe:privacy-policy

Conversation

@alienqqe

Copy link
Copy Markdown
Contributor

Description

Added privacy policy route that helps people to understand terms of using our project

Fixes #149

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
bandicam.2023-08-29.16-14-50-802.mp4

@alienqqe
alienqqe requested a review from gbowne1 as a code owner August 29, 2023 13:27
@gbowne1
gbowne1 requested a review from LOGESH-B August 29, 2023 16:52
@gbowne1 gbowne1 added the enhancement New feature or request label Aug 29, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Aug 29, 2023

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out this change locally for testing and review for merge
  • Manually reviewed all commits and code for errors
  • Reviewed in browser console for errors and warnings

This PR change consists of adding a Privacy Policy to our app. It does not appear to add any significant bugs to the app.

My only comment is that the Privacy Policy should also be applied to the link that is visible during the Login/Register -- Sign Up/Sign In process. Otherwise, this change is acceptable as is.

Approving for merge.

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @alienqqe
Thanks for your contribution🙌

This PR creates PrivacyPolicy Page...
Approving for merge

@LOGESH-B
LOGESH-B merged commit 6741896 into gbowne1:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEAT] Add a page for /privacy-policy route

3 participants