Skip to content

Fixing .variable-env and Home.jsx component - #147

Merged
gbowne1 merged 1 commit into
masterfrom
gbowne1-hotfix-home-component
Aug 28, 2023
Merged

Fixing .variable-env and Home.jsx component#147
gbowne1 merged 1 commit into
masterfrom
gbowne1-hotfix-home-component

Conversation

@gbowne1

@gbowne1 gbowne1 commented Aug 27, 2023

Copy link
Copy Markdown
Owner
  • Tested this locally to make sure that the App will now render with no ESLint errors or warnings.

This PR fixes the useEffect in the Home.jsx component so that the app will render. This might need some more cleanup work in the future, but am returning the component to working status anyways.

This PR also fixes the .variable.env file so that it can be more easily used to set up the project.

Edit: this will also fix #143

@gbowne1 gbowne1 added the bug Something isn't working label Aug 27, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Aug 27, 2023
@gbowne1
gbowne1 requested a review from LOGESH-B August 27, 2023 23:30
@gbowne1 gbowne1 self-assigned this Aug 27, 2023
@gbowne1 gbowne1 linked an issue Aug 27, 2023 that may be closed by this pull request

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @gbowne1
Did you have some sample books data ... We can write code on setup.js file to insert in the db Which will be added to db on the initial run of setup.js

@gbowne1

gbowne1 commented Aug 28, 2023

Copy link
Copy Markdown
Owner Author

@LOGESH-B

That would be a huge task as I have well over 300 books on coding/programming. That would be near impossible by hand. The books I entered on data.json are all valid books. That data could be used. I am not sure that all of them need done for setup, only a few to get the data entry started.

@gbowne1
gbowne1 merged commit 0bb8a61 into master Aug 28, 2023
@LOGESH-B

LOGESH-B commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

My sugession is that,
we can have some 10 to 20 books for now,that we can add by default at running of setup file...Instead of showing nothing/(data from data.json file) on initial home page we can render the books from db

@gbowne1

gbowne1 commented Aug 28, 2023

Copy link
Copy Markdown
Owner Author

Yeah, agreed. Well the data I had in data.json are actual books so that could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] useEffect has a missing dependency

2 participants