User profile page - #146
Merged
Merged
Conversation
gbowne1
added
enhancement
gbowne1
approved these changes
Aug 26, 2023
gbowne1
left a comment
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- Checked out this change locally for testing and review
- reviewed manually for errors after checkout
This change works as expected. It adds the initial User Profile accessible by using the dropdown context menu by clicking on the (R) icon in the topnav and then clicking Profile.
I did not find that this change added any significant errors to the codebase and works as expected.
Approving for merge
Owner
|
@ratishjain12 @LOGESH-B @BlackBond06 Should we add a feature that would allow users to search the user database to find people who use the app who have read, reviewed, etc the same coding books in the database? |
Collaborator
|
100%. That will be very cool. |
LOGESH-B
approved these changes
Aug 27, 2023
LOGESH-B
left a comment
LOGESH-B
left a comment
Collaborator
There was a problem hiding this comment.
Hii @ratishjain12
Thanks for your contribution✌️
Got some warnings, but it can be rectified in upcomming PRs
Approving for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #50
@gbowne1 fixed merge conflicts