remove/warnings - #144
Merged
Merged
Conversation
gbowne1
approved these changes
Aug 25, 2023
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- checked out this change locally for testing and review
- manually reviewed for styling and errors
This change mostly does a prettify cleanuo of the code which is needed to eliminate code styling errors that exist.
I will test more in the afternoon tomorrow and possibly fix the rest of the issue then.
Thanks for the opportunity to review your PR @LOGESH-B
Approving for merge
Owner
|
@LOGESH-B I believe I can fix this as I described in the issue during my time tomorrow. Thanks for cleaning up the prettier errors. Merging |
Owner
|
I only see a minor issue with CSS in the search bar I've been reviewing the console each page and with items open and closed and haven't found much yet. We have some really good features. Waiting to see what @BlackBond06 & @ratishjain12 come up with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hii @gbowne1
I can't get the dependency error but I get another error that location.state.loggin is undefined
But it also resolved once I logged in again
I removes the Prettier errors On this PR
(Solves issue #143 )