Skip to content

remove/warnings - #144

Merged
gbowne1 merged 1 commit into
gbowne1:masterfrom
LOGESH-B:remove/warnings
Aug 25, 2023
Merged

remove/warnings#144
gbowne1 merged 1 commit into
gbowne1:masterfrom
LOGESH-B:remove/warnings

Conversation

@LOGESH-B

Copy link
Copy Markdown
Collaborator

Hii @gbowne1

I can't get the dependency error but I get another error that location.state.loggin is undefined
But it also resolved once I logged in again
I removes the Prettier errors On this PR
(Solves issue #143 )

@LOGESH-B LOGESH-B self-assigned this Aug 25, 2023
@LOGESH-B
LOGESH-B requested a review from gbowne1 as a code owner August 25, 2023 06:58

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked out this change locally for testing and review
  • manually reviewed for styling and errors

This change mostly does a prettify cleanuo of the code which is needed to eliminate code styling errors that exist.

I will test more in the afternoon tomorrow and possibly fix the rest of the issue then.

Thanks for the opportunity to review your PR @LOGESH-B

Approving for merge

@gbowne1

gbowne1 commented Aug 25, 2023

Copy link
Copy Markdown
Owner

@LOGESH-B I believe I can fix this as I described in the issue during my time tomorrow.

Thanks for cleaning up the prettier errors.

Merging

@gbowne1 gbowne1 added the bug Something isn't working label Aug 25, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Aug 25, 2023
@gbowne1
gbowne1 merged commit 3efca8a into gbowne1:master Aug 25, 2023
@gbowne1

gbowne1 commented Aug 25, 2023

Copy link
Copy Markdown
Owner

I only see a minor issue with CSS in the search bar

I've been reviewing the console each page and with items open and closed and haven't found much yet.

We have some really good features. Waiting to see what @BlackBond06 & @ratishjain12 come up with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants