Style the login and register page - #117
Merged
LOGESH-B merged 2 commits intoAug 4, 2023
Merged
Conversation
gbowne1
approved these changes
Aug 4, 2023
gbowne1
left a comment
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- checked out this change locally for testing and review
This change adds styling to the login and register pages and appears as expected in the browser view and also the screenshots provided with this PR.
Approving for merge.
Thanks for your contribution @kabszac
LOGESH-B
requested changes
Aug 4, 2023
Collaborator
There was a problem hiding this comment.
Hii @kabszac
Great Work and Ui also looks simple and neat
I got one issue with the mobile view of signin Page
I Attached the Image below
- Can you work on that(Signin Page) to make it responsive
- And also make link to only Signin text you make Link to all (i.e Already Have Account)text
I am mensioning this because its not big deal now but it is a small change that can be done now
Otherwise functionality wise all good✅✌️
Owner
Contributor
Author
|
@LOGESH-B 'And also make link to only Signin text you make Link to all (i.e Already Have Account)text'. I did not understand what I'm supposed to do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #113 I worked on the login page and made changes to login.jsx and login.css
@gbowne1
the new sign in:
I made changes to the register.jsx to add styling.
Old Sign up:
New sign up: