Skip to content

Adding Register UI - #105

Merged
LOGESH-B merged 3 commits into
masterfrom
gbowne1-add-register-ui
Jul 29, 2023
Merged

Adding Register UI#105
LOGESH-B merged 3 commits into
masterfrom
gbowne1-add-register-ui

Conversation

@gbowne1

@gbowne1 gbowne1 commented Jul 28, 2023

Copy link
Copy Markdown
Owner

This commit adds a Register or Sign Up page so that the user can register or sign up for the app.

It also adds the remaining fixes for the Login page UI including the initial CSS.

This commit adds a Register or Sign Up page so that the user can register or sign up for the app.
@gbowne1 gbowne1 added the enhancement New feature or request label Jul 28, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Jul 28, 2023
@gbowne1 gbowne1 self-assigned this Jul 28, 2023
@gbowne1 gbowne1 linked an issue Jul 28, 2023 that may be closed by this pull request
@gbowne1
gbowne1 requested a review from LOGESH-B July 28, 2023 00:49
@LOGESH-B

LOGESH-B commented Jul 28, 2023

Copy link
Copy Markdown
Collaborator

Hii @gbowne1

npx eslint --fix . doesn't fix the problem
image

  • Unable to vew changes🥴

@gbowne1

gbowne1 commented Jul 28, 2023

Copy link
Copy Markdown
Owner Author

@LOGESH-B

Yes, That is because they weren't defined. ESLint won't fix undefined errors. I am going to work on that today later on as its 5am and commit the rest of the fix to this PR branch.

@gbowne1

gbowne1 commented Jul 28, 2023

Copy link
Copy Markdown
Owner Author

Login should be viewed at /login just fine

I don't think /register had a route yet so that won't show up.

@LOGESH-B

Copy link
Copy Markdown
Collaborator

Login should be viewed at /login just fine

I don't think /register had a route yet so that won't show up.

No In login also same error
image

@gbowne1

gbowne1 commented Jul 28, 2023

Copy link
Copy Markdown
Owner Author

It won't render if you're on the master branch since it isn't merged yet.

There already is a /login route so should render just fine if you're on this PR branch.

Either way I will fix this in a few hours and push to this PR branch.

Oh and if ESLint renders a X in the corner you should be able to close the error overlay and see what is rendering.

@gbowne1

gbowne1 commented Jul 28, 2023

Copy link
Copy Markdown
Owner Author

@LOGESH-B

I believe I fixed it. It should render just fine now.

The new login screen. Will render at /login
Screenshot 2023-07-28 at 14-57-47 React App

New Register screen UI. Will render at /register
Screenshot 2023-07-28 at 15-07-26 React App

I added a route for /register in App.js

Yeah, its not styled that well just yet. needs plenty of styling work someone can do.

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally Working fine ..Aproving for merge✌️

@LOGESH-B
LOGESH-B merged commit 3f7959d into master Jul 29, 2023
@gbowne1

gbowne1 commented Jul 29, 2023

Copy link
Copy Markdown
Owner Author

Thanks 👍

@gbowne1
gbowne1 deleted the gbowne1-add-register-ui branch July 29, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[TODO] Create a Register page

2 participants