[christmas] Gate home page draw boards behind local-storage watch state - #396
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the home page, draws that haven't been watched yet are now hidden behind a "Not opened yet" placeholder that links to the pool page's reveal ceremony, matching the gate that already exists there. Once a draw has been watched (recorded in local storage), the cycle board appears as before.
To avoid handing names to the viewer before the pool page's ceremony has a chance to run, the home page defers reading local storage until after the first render — the same approach the pool page already uses. The revision badge is also now restricted to managers, since showing it to a regular viewer would hint that earlier draws exist, undermining the point of hiding them.
The
storagemodule's documentation is updated to make clear that these helpers control presentation only, not access: the pairings are already in the server's response, so local storage is a courtesy for the reveal experience rather than a security boundary.