[christmas] drop the "Slug" column from the admin pools table - #395
Draft
gazure wants to merge 1 commit into
Draft
[christmas] drop the "Slug" column from the admin pools table#395gazure wants to merge 1 commit into
gazure wants to merge 1 commit into
Conversation
"Slug" is developer vocabulary; a pool manager reading the admin panel has no reason to know it. The column's only real use was getting to a pool's page, so the name cell becomes that link instead and the raw slug stops being presented at all. The value itself is untouched — it still keys the /pools/:slug route. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last user-facing use of the word "slug". The admin Pools table showed a
Slugcolumn with the raw value — developer vocabulary a pool manager has no reason to know.The column's only practical use was navigating to a pool, so the Name cell is now a link to
/pools/:slugand the raw slug is no longer displayed. The value itself is unchanged: it still keys the route, the model, and the tests.Every other occurrence of
sluginchristmasis internal (route parameter,Pool::slug,Exchange::pool_slug) and never rendered.Checks:
cargo clippy -p christmas --all-features --all-targetsclean,cargo +nightly fmt --allapplied,cargo test -p christmas --lib50/50 passing.🤖 Generated with Claude Code