ci: add codeflash - #88
Merged
Merged
Conversation
Reviewer's GuideIntegrate Codeflash for automated code optimization by adding it as a dev dependency and configuring its settings, update the environment file path in mise.toml, and introduce a GitHub Actions workflow to run Codeflash on pull requests. Class diagram for Codeflash configuration in pyproject.tomlclassDiagram
class CodeflashConfig {
+String module-root = "src"
+String tests-root = "tests"
+String test-framework = "pytest"
+List ignore-paths = []
+List formatter-cmds = ["ruff check --exit-zero --fix $file", "ruff format $file"]
}
class PyProjectToml {
+CodeflashConfig tool.codeflash
}
PyProjectToml --> CodeflashConfig
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @gazorby - I've reviewed your changes - here's some feedback:
- The Codeflash workflow only triggers on src/** changes — consider also including tests and configuration file paths so optimizations aren’t missed for those files.
- You switched the mise.toml
_.filefrom .env.json to .env; please confirm any env‐loading logic in the codebase is updated to read from the new .env file. - In the [tool.codeflash] config you run both “ruff check --exit-zero --fix” and “ruff format” on $file; consider consolidating to a single fix command to avoid redundant formatting passes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Codeflash workflow only triggers on src/** changes — consider also including tests and configuration file paths so optimizations aren’t missed for those files.
- You switched the mise.toml `_.file` from .env.json to .env; please confirm any env‐loading logic in the codebase is updated to read from the new .env file.
- In the [tool.codeflash] config you run both “ruff check --exit-zero --fix” and “ruff format” on $file; consider consolidating to a single fix command to avoid redundant formatting passes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Integrate Codeflash into the project by adding it to development dependencies, configuring it, and setting up a GitHub Actions workflow to optimize code on pull requests.
New Features:
Enhancements:
Build:
CI: