Skip to content

docs: _SQLiteJSONComparison docstring lists contains/contained_in it does not have #401

Closed

Description

@gazorby

_SQLiteJSONComparison (src/strawchemy/schema/filters/inputs.py:445-465) declares only has_key, has_key_all and has_key_any, but its docstring's Attributes section, copied from _JSONComparison, also lists contains and contained_in. Its summary also mentions filtering "based on containment".

JSONFilter._sqlite_json (src/strawchemy/schema/filters/base.py) has no containment branch, and the integration tests skip contains/containedIn on SQLite (tests/integration/data_types/test_json.py).

Also, make_sqlite_json_comparison_input (inputs.py:476-479) publishes it under the same GraphQL name JSONComparison and the same "json" description as the full input. The schema doesn't tell SQLite users that containment is unsupported.

Fix: remove the two attributes and the containment wording from the docstring. Optionally, give the SQLite input a description that says containment is unsupported.

Activity

  1. gazorby commented on Sep 29, 2026

    @gazorby
    OwnerAuthor

    Fixed on the docs-website branch: the _SQLiteJSONComparison docstring drops contains/contained_in and states that SQLite lacks containment operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions