Change Bazel to use Clang for layering checks - #953
Open
luca-della-vedova wants to merge 7 commits into
Open
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/fix_bazel_layering_checks
branch
from
September 1, 2026 07:58
8595b7d to
f9dc34f
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/fix_bazel_layering_checks
branch
from
September 1, 2026 08:46
57cbb1a to
faa7e7f
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/fix_bazel_layering_checks
branch
from
September 2, 2026 01:51
e1cc40d to
d4f8fe7
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Comment on lines
+52
to
+59
| # TODO(anyone) Remove when bumping to zenoh-cpp 1.8.0 that has the fix merged in | ||
| single_version_override( | ||
| module_name = "zenoh-cpp", | ||
| patch_strip = 0, | ||
| patches = [ | ||
| "//patches:zenoh_cpp_cancellation.patch", | ||
| ], | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a bummer, but should be straightforward to remove later
luca-della-vedova
marked this pull request as ready for review
September 2, 2026 04:04
|
Tracking issue: gazebo-tooling/gz-bazel-dev#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
WIP, fix CI / builds with Clang. Was not detected in original Bazel CI PR because the workflow doesn't run mac CI on branches, it only runs it after it is merged to main.
Summary
WIP, first commit changing build to be with Clang to enable layering checks, will work towards green CI.
Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.