Add explicit MessageT Subscribe and CreateSubscriber template overloads for callbacks - #912
Open
azeey wants to merge 2 commits into
Open
Add explicit MessageT Subscribe and CreateSubscriber template overloads for callbacks#912azeey wants to merge 2 commits into
azeey wants to merge 2 commits into
Conversation
…ds for callbacks
Support explicit template parameters for capturing lambda callbacks
(e.g. node.Subscribe<MsgT>(topic, [&](const MsgT&) {}))
without ambiguity.
Assisted-by: Gemini 3.6 Flash
Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #880
Summary
Currently,
Node::SubscribeandNode::CreateSubscriberdeduce the message type from the provided callback. However, this causes compilation ambiguities when using callbacks that require explicit template arguments (such as lambda functions).This PR introduces new template overloads for
Node::SubscribeandNode::CreateSubscriberthat allow users to explicitly specify theMessageTtemplate parameter. This completely eliminates ambiguities for capturing lambdas.Example usage:
Note: As documented in the headers, using non-capturing lambdas with explicit template arguments still results in an ambiguity with the function pointer overload. This is marked with a TODO to be addressed in a follow-up.
Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini 3.6 Flash
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.