cmake: Search Development.Module Python component to compile Python bindings (backport #840) - #841
Merged
Merged
Conversation
mergify
Bot
requested review from
adityapande-1995 and
scpeters
as code owners
September 4, 2026 18:21
19 tasks
scpeters
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes looking for
Developmentcmake component of Python even if it was necessary.Summary
CMake's FindPython offers two dev-related component of Python:
Development.ModuleandDevelopment.Embed(see https://cmake.org/cmake/help/latest/module/FindPython.html), orDevelopmentto search both. As gz-math is not embedding python, it only needDevelopment.Module.This is relevant in conda-forge since Python 3.15 split the files necessary for
Development.Embedto suceed inlibpython, so packages that only depend onpythonand do not embed python, need to only look forDevelopment.Module, see conda-forge/gz-math-feedstock#46 (comment) .Backport Policy
Development.Modulerequires CMake 3.18, so we can backport to any version that has a greater minimum CMake version.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #840 done by [Mergify](https://mergify.com).