Fix Plane intersection Python defaults - #834
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
Fix Plane intersection Python defaults#834timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex (GPT-5.6) Signed-off-by: Timothy Anderson <timothyanderson096@gmail.com>
timothyanderson096-ocdealcheck
requested review from
adityapande-1995 and
scpeters
as code owners
August 26, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Refs #808.
Summary
Plane.intersection()currently accepts calls without a point or gradient even though the C++ API requires both arguments. This change removes those two Python binding defaults, retains the optional tolerance, and adds regression coverage for zero- and one-argument calls.Before this change,
plane.intersection()is accepted. After this change, missing point or gradient arguments raiseTypeError, while the two-argument call succeeds and_toleranceremains optional.Backport Policy
Testing
mainwith a focused harnessPlane.intersection()with zero argumentsTypeErrorfor missing point / gradientgit diff --checkThe full CMake suite was not run locally because the test container does not include the project's CMake dependencies.
Checklist
codecheckpassedAssisted-bytrailerSome portions of this pull request were generated using OpenAI Codex (GPT-5.6).
Assisted-by: OpenAI Codex (GPT-5.6)