local: gracefully fail if the lock is already taken - #321
Merged
Conversation
An EACCES or EAGAIN error on a non-blocking lockf is not actually an error, but rather the program working as intended. At this stage, any other error is unexpected and should probably be left alone. The tailor-made exception can be caught in our main function to display a short error string and use a specific error code for the user to act accordingly. This is much more user-friendly (and machine-friendly) than the standard python uncaught exception handler.
Owner
|
Hi, what's the point of this PR? It seems to just fail with a slightly different error message? |
Contributor
Author
|
The point of this PR is to differentiate this error, which is a frequent and benign user error. Since it's benign, it shouldn't fill your terminal with a stack trace, and it's nice to have a specific error code (randomly, 7), so that any automation can just deal with it accordingly, e.g. simply suppress it. |
Owner
|
Ok. Good, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An EACCES or EAGAIN error on a non-blocking lockf is not actually an error, but rather the program working as intended. At this stage, any other error is unexpected and should probably be left alone.
The tailor-made exception can be caught in our main function to display a short error string and use a specific error code for the user to act accordingly. This is much more user-friendly (and machine-friendly) than the standard python uncaught exception handler.