Workaround with dhcp library fork to add padding after boot filename for buggy motherboard - #117
Open
scufre wants to merge 1 commit into
Open
Workaround with dhcp library fork to add padding after boot filename for buggy motherboard#117scufre wants to merge 1 commit into
scufre wants to merge 1 commit into
Conversation
…for buggy motherboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying this nice project with an old computer I have (from around 2010) I've found that when it was requesting the initial boot file through TFTP, it was appending some extract character and on the computer it displayed even another non ASCII character. After digging around found this https://binaryfury.wann.net/2024/12/pxe-two-tftp-filenames-one-dhcp-offer-plus-weird-filenames/, where it seems that the bootfile option is interpreted as null terminated string which is wrong.
Submitted this PR to the dhcp library.
Here is a PR with a minimum change leveraging the dhcp PR, to workaround this, adding a padding option after the bootfile. With this, I got the old computer to boot!
Hope that PR gets merged so you can incorporate this little change.