Apply per-client bootloader set overrides - #115
Open
hcaldicott wants to merge 9 commits into
Open
Conversation
Author
|
GPT 5.6 was used in this PR, however I have completed a manual (human) review of the codebase. I (personally) am happy with the changes here and feel they're as minimal as possible to implement the given functionality. I am still pulling apart the unit tests though and validating them. |
hcaldicott
marked this pull request as ready for review
August 11, 2026 05:23
added 6 commits
August 11, 2026 23:52
This reverts commit cb7504a.
# Conflicts: # internal/server/menu.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The client and client-group
bootloader_setfields are persisted and exposedby the UI, but the boot-serving path only consults
GetActiveBootloaderSet().Consequently, the per-client override advertised in the v0.1.13 release notes
has no effect during PXE boot.
proxyDHCP knows the requesting MAC, while the later TFTP request only carries a
filename. This change resolves the effective set during proxyDHCP and advertises
a path such as
bootloader-sets/custom/bootimus.efi, preserving that choice forthe subsequent transfer.
Unqualified requests continue to resolve through the global active set, so
external DHCP configurations retain their existing behaviour.
Validation
gofmt -l .go vet ./...go test ./...go test -race ./internal/proxydhcp ./internal/servergo build ./...GOOS=windows GOARCH=amd64 go build ./...GOOS=darwin GOARCH=arm64 go build ./...Fixes #116. Related global bootloader/proxyDHCP wiring: #78 and #96.