v1.63.0.0 feat(gbrain): make repository indexing verifiable and fail-closed - #2377
Open
mamedov wants to merge 5 commits into
Open
v1.63.0.0 feat(gbrain): make repository indexing verifiable and fail-closed#2377mamedov wants to merge 5 commits into
mamedov wants to merge 5 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
|
@codex review |
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
/sync-gbrainrepository indexing fail closed and prove exactly which clean repository commit and immutable content plan were applied.auto, trusted.gbrain-source, final source registry state, and one preview/applyplan_digest.--verify-receiptto rebind persisted evidence to the live canonical root, attached source, and current clean HEAD without contacting GBrain.Safety and deterministic behavior
0.42.71.0or newer.state_changed: registry_only; a later invocation syncs after registration is independently observable.--dry-runis a true no-probeORCHESTRATION PREVIEW — unvalidated: it performs no Git, engine, source, lock, path, or content probes and makes no writes.dry_run/validated_index_plan, requires a full lowercase SHA-256plan_digest, passes it through--expected-plan-digest, and accepts success only when apply echoes the same digest.plan_changedpreserves validated observed/required digests and refuses before mutation.auto..gbrain-sourceis replaced by gstack through a same-directory exclusive temporary file and atomic rename, so a raced symlink is not followed.search_readyis true if and only if embedding and extraction are both complete.Review-driven hardening
gstack-gbrain-sync; generated host skills now resolve the same runnable entry point./setup-gbraindelegates repository writes to the safe wrapper instead of raw import/background embedding paths.plan_digestinstead of telling operators to remove--dry-run.Verification
Current reviewed commit:
63308e25115bc48cfb7de093aec257bf9094897abun test test/gbrain-repository-index.test.ts test/gstack-gbrain-sync.test.ts test/gbrain-sync-skip.test.ts test/skill-e2e-memory-pipeline.test.ts test/host-config.test.ts test/gen-skill-docs.test.tsbun run buildpassed and regenerated every supported host artifact.git diff --checkpassed.ALREADY_BUMPED(1.60.1.0→1.63.0.0).Full-suite baseline caveat
An earlier full
bun testrun exited 1 solely because three pre-existingtest/brain-cache-roundtrip.test.tscases time out at the 5-second test limit when a usable local GBrain is installed. A focused reproduction produced 11 passed / 3 failed. The affected brain-cache implementation and test paths are unchanged fromorigin/main. Follow-up: https://3.basecamp.com/4058523/buckets/34718435/card_tables/cards/10141872751Tracking
Basecamp card: https://3.basecamp.com/4058523/buckets/34718435/card_tables/cards/10135180500
Release status
No release, installation, merge, or deployment was performed. This PR prepares the
v1.63.0.0code, documentation, tests, and version metadata for review.