v1.60.2.0 fix(codex): keep gstack catalog within prompt budget - #2363
Open
cuddly-life wants to merge 2 commits into
Open
v1.60.2.0 fix(codex): keep gstack catalog within prompt budget#2363cuddly-life wants to merge 2 commits into
cuddly-life wants to merge 2 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$skill-name.Why
The generated Codex install exposes 54 gstack descriptions in the always-loaded skill catalog. Together they exceeded the catalog budget and triggered description shortening at session startup.
This reduces the generated catalog to 3,854 description characters (71 average, 208 maximum) without removing workflow instructions or natural-language routing.
Related work
Related to #1972. This implementation is rebased onto current
main, scoped to Codex, preserves implicit routing, fixes generated$skill-nameprompts, and adds positive and negative routing-preservation coverage.Test Coverage
All changed generator paths have focused regression coverage.
Pre-Landing Review
Reviewer concerns around hidden child skills and overly broad YAML changes were resolved. No remaining blocking findings.
Design Review
No frontend files changed — design review skipped.
Plan Completion
No plan file detected.
Verification
bun run gen:skill-docs --host allbun run gen:skill-docs --host all --dry-runbun test --timeout 15000 test/gen-skill-docs.test.ts(403 pass)bun test test/host-config.test.ts(77 pass)bun run buildgit diff --checkKnown repository-wide gate limitations
bun testwas attempted; the all-files parallel run encountered unrelated timing and shared-state failures in discovery, gbrain, repo-mode, and detach suites. The changed generator and host suites pass in isolation.bun run skill:checkreports the intentional absence ofclaude/SKILL.md; all 54 Codex skills and all generated-host freshness checks pass.