fix(codex): resolve review resources via runtime root - #2348
Open
uncfreak1255-code wants to merge 1 commit into
Open
fix(codex): resolve review resources via runtime root#2348uncfreak1255-code wants to merge 1 commit into
uncfreak1255-code wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$GSTACK_ROOT/review/shipgolden fixture and update generator regressionsVerification
bun test test/gen-skill-docs.test.ts test/host-config.test.ts test/setup-windows-fallback.test.ts— 488 passedbun run build— passed--mode local) — clean, no actionable findings.agents/skills/gstack/review/...review-resource references remainbun run eval:select— 0/181 E2E and 0/28 LLM-judge tests selectedKnown base/toolchain exceptions
bun run test:windowsreaches an untouchedorigin/mainassertion mismatch:test/helpers/observability.test.tsexpects six/* non-fatal */markers whileorigin/main:test/helpers/session-runner.tscontains five. This branch has no diff in either file.bun run test:evalsselected no model tests and spent$0.00, but an always-loaded Swift fixture test cannot importXCTestbecause this machine has Command Line Tools only, not full Xcode. The Swift test and fixture are unchanged fromorigin/main.These exceptions are documented rather than patched here to keep the change scoped to Codex resource resolution.