Skip to content

fix(codex): resolve review resources via runtime root - #2348

Open
uncfreak1255-code wants to merge 1 commit into
garrytan:mainfrom
uncfreak1255-code:fix/codex-review-resource-paths
Open

fix(codex): resolve review resources via runtime root#2348
uncfreak1255-code wants to merge 1 commit into
garrytan:mainfrom
uncfreak1255-code:fix/codex-review-resource-paths

Conversation

@uncfreak1255-code

Copy link
Copy Markdown

Summary

  • rewrite Codex review-resource references to $GSTACK_ROOT/review
  • declare all four review runtime resources, including design and Greptile checklists
  • regenerate the Codex /ship golden fixture and update generator regressions
  • execute the generated preamble in temporary consumer repos to prove global and repo-local installations both resolve every review resource

Verification

  • bun test test/gen-skill-docs.test.ts test/host-config.test.ts test/setup-windows-fallback.test.ts — 488 passed
  • bun run build — passed
  • Codex Autoreview (--mode local) — clean, no actionable findings
  • generated-path scan — no .agents/skills/gstack/review/... review-resource references remain
  • bun run eval:select — 0/181 E2E and 0/28 LLM-judge tests selected

Known base/toolchain exceptions

  • bun run test:windows reaches an untouched origin/main assertion mismatch: test/helpers/observability.test.ts expects six /* non-fatal */ markers while origin/main:test/helpers/session-runner.ts contains five. This branch has no diff in either file.
  • bun run test:evals selected no model tests and spent $0.00, but an always-loaded Swift fixture test cannot import XCTest because this machine has Command Line Tools only, not full Xcode. The Swift test and fixture are unchanged from origin/main.

These exceptions are documented rather than patched here to keep the change scoped to Codex resource resolution.

@trunk-io

trunk-io Bot commented Jul 25, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant