Skip to content

Suppress accessibility updates at rating boundaries#23

Merged
garethpaul merged 1 commit into
masterfrom
fix/accessibility-boundary-noop
Jun 26, 2026
Merged

Suppress accessibility updates at rating boundaries#23
garethpaul merged 1 commit into
masterfrom
fix/accessibility-boundary-noop

Conversation

@garethpaul

@garethpaul garethpaul commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat bounded accessibility increment and decrement actions as no-ops.
  • Avoid duplicate completed-update callbacks and bounce feedback when the rating cannot change.
  • Cover both minimum and maximum boundaries in native and portable tests.

Baseline

Accessibility adjustment at a rating boundary could still trigger update feedback and completion behavior even though the visible rating could not change.

Improvements

  • Suppress boundary updates when increment or decrement would exceed the allowed rating range.
  • Preserve successful accessibility changes within bounds.
  • Add minimum/maximum regression and portable static contracts.

Validation

  • The current exact head 4d13bc857c3fe32c12cb37e268d913ad2f70cb63 passed identical six-context portable matrices in two fresh clones.
  • Three exact-head hosted checks succeeded, including the macOS baseline simulator/sample-build authority.
  • No IP network operations occurred, and redacted history/current-tree secret scans found zero findings.
  • Branch protection remains strict and no pull requests are open.

Risk

  • Boundary gestures now intentionally produce no callback or bounce feedback when the rating cannot change.
  • Local Linux validation cannot execute Xcode or simulator tests; hosted macOS remains the native authority.

Follow-Ups

  • Keep minimum and maximum accessibility behavior covered by native XCTest and the portable baseline.
  • Revalidate callback semantics if the rating range or accessibility interaction model changes.

@garethpaul
garethpaul merged commit 85b0c73 into master Jun 26, 2026
5 checks passed
@garethpaul
garethpaul deleted the fix/accessibility-boundary-noop branch June 26, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant