Do not treat empty PVC fetch results as errors - #303
Open
plkokanov wants to merge 3 commits into
Open
Conversation
gardener-prow
Bot
added
area/ops-productivity
RadaBDimitrova
left a comment
RadaBDimitrova
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, I have just a wording suggestion.
Kostov6
reviewed
Jul 29, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RadaBDimitrova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
approved
Kostov6
reviewed
Aug 5, 2026
Kostov6
left a comment
Kostov6
left a comment
Contributor
There was a problem hiding this comment.
Minor nit, otherwise lgtm
| logger.V(2).Info("no persistentvolumeclaims found for persistentvolumeclaimautoscaler", "pvca", pvcaKey, "reason", err.Error()) | ||
|
|
||
| reason = ReasonNoPVCsMatched | ||
| message = fmt.Sprintf("Failed to fetch PersistentVolumeClaims: %s", err.Error()) |
Contributor
There was a problem hiding this comment.
Is this meaningfully different from L283?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ops-productivity
/kind cleanup
What this PR does / why we need it:
Previously,
internal/target/pvcfetcher.Fetchfunciton returned errors when no pods matched a selector or when matching pods had no PVC volumes. This caused the runner to set theReasonPVCFetchErrorcondition for situations that are not errors, e.g. when a workload is scaled down to 0.With this PR the
internal/target/pvcfetcher.Fetchno longer returns errors in such cases, and just an empty/nil list of PVCsIn such cases the runner will just print a debug log and set the
RecommendationAvailableandResizingconditions appropriately, to indicate that no PVCs were matched.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: