hvpa redesign by ggaurav10 · Pull Request #76 · gardener-attic/hvpa-controller

ggaurav10 · 2020-08-10T07:17:20Z

What this PR does / why we need it:
hvpa redesign

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Refer this for design details

Release note:

Change API Group to `autoscaling.gardener.cloud`

Implement scale subresource - Now HPA, if deployed, will scale HVPA's scale subresource instead of the HVPA's target

The scaling is not based on HPA/VPA weightage anymore. Max of total resources recommended by HPA/VPA is considered for scaling based on provided scale intervals.

`baseResourcesPerReplica` and `baseResourcesPerReplica` fields and implementation handling of paradoxical scaling

…into bucketwithscale

…iners' VPA minAllowed values

amshuman-kr

Thanks a lot @ggaurav10 for the substantial changes ❤️
The PR really looks good now!

Only some minor questions/suggestions 🙂

amshuman-kr

Thanks @ggaurav10 for good test coverage! As discussed offline, the main code line looks good.

Just a few questions and perhaps a 3-4 more test cases to cover some other scenarios.

Also, would it be possible to use the relevant formula (or even a test utility function call) in the expected value rather than code it in as a constant? That might make the test cases more readable.

amshuman-kr · 2020-09-02T04:45:27Z

 				return h.Status.OverrideScaleUpStabilization
 			}, timeout).Should(BeTrue())

+			// Update VPA status, let HVPA scale


Should we cover the update HPA and let HVPA scale case too?

Also, can we include a couple of more entries where HPA and/or VPA deployment is disabled?

amshuman-kr · 2020-09-09T07:10:09Z

 			},

-			Entry("UpdateMode Auto, Should Scale only memory", &data{
+			Entry("UpdateMode Auto, scale up, paradoxical scaling, replicas increases, resources per replica decreases", &data{


Suggested change

Entry("UpdateMode Auto, scale up, paradoxical scaling, replicas increases, resources per replica decreases", &data{

Entry("UpdateMode Auto, scale up, paradoxical scaling, replicas increases, resources per replica decrease is blocked", &data{

amshuman-kr · 2020-09-09T07:27:04Z

+					},
+				},
+			}),
+			Entry("UpdateMode Auto, overall scale up, paradoxical scaling, but replicas decrease - should not be considered paradoxical", &data{


If I understood right, this case is where the current replicas and requests are such that they are not within the right effective scaling interval for the currentReplicas and the recommendation results in a scale up but the effective scaling interval has the desiredReplicas < currentReplicas. Is that correct?

Related to this scenario, could we also cover change in scaling interval spec such that the current replicas and requests that were valid for the effective scaling interval earlier but are now no longer valid after the spec change (for no change in recommendations, scale up and down)?

Is that correct?

Yes

Related to this scenario, could we also cover change in scaling interval spec such that the current replicas and requests that were valid for the effective scaling interval earlier but are now no longer valid after the spec change (for no change in recommendations, scale up and down)?

will add in next commit

amshuman-kr · 2020-09-09T07:34:46Z

+				},
 			}),
-			Entry("UpdateMode Auto, Proportional scaling", &data{
+			Entry("UpdateMode Auto, scale down hysteresis", &data{


Suggested change

Entry("UpdateMode Auto, scale down hysteresis", &data{

Entry("UpdateMode Auto, scale down hysteresis based on scaling intervals overlap", &data{

Is the scale up side of this covered?

Can we add a couple of cases (scale up and down) without scaling interval gaps configured?

scale down hysteresis due to ScalingIntervalsOverlap is covered in this case. scale up hysteresis is provided by minChange which is covered in test case - UpdateMode Auto, scale up blocked due to minChange

scale up hysteresis is provided by minChange which is covered in test case - UpdateMode Auto, scale up blocked due to minChange

Understood. But I meant a specific case for scale up hysteresis where minChange doesn't block. I.e. scale up happens within the current bucket even though the next bucket's min total resources is higher than the scaled up total resources. WDYT?

ah ok.. sure. will add.

CLAassistant · 2020-09-16T10:37:49Z

All committers have signed the CLA.

amshuman-kr · 2021-08-31T19:48:22Z

/close in favour of #88

Gaurav Gupta added 9 commits March 30, 2020 17:00

Added Scale subresource support

889233a

Handle case when a container mode is set to "Off" in VPA spec

b69073e

Added test cases

ca5db7b

Adding edge test case: When deployment replicas == 0

b7ce106

Introduce bucket thresholds

1619244

Changing bucket strategy

1d0db5d

Added:

a72f3e5

`baseResourcesPerReplica` and `baseResourcesPerReplica` fields and implementation handling of paradoxical scaling

Rebase: Merge branch 'master' of github.com:gardener/hvpa-controller …

6551631

…into bucketwithscale

Apply scaling intervals to per container instead of per pod

d2af90d

ggaurav10 requested a review from a team August 10, 2020 07:17

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 13, 2020

Refactor code

6b1d221

ggaurav10 force-pushed the bucketwithscale branch from fefd653 to 6b1d221 Compare August 13, 2020 07:55

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

Merge branch 'master' into bucketwithscale

2944605

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

No scaling when .spec.replicas is 0

e9c84b9

ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

code cleanup

2942e00

ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2020

Generate different buckets for each containers using individual conta…

a0ba05f

…iners' VPA minAllowed values

ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020

ghost added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 25, 2020

amshuman-kr reviewed Aug 26, 2020

View reviewed changes

Review comments addressed

b52c926

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 27, 2020

amshuman-kr suggested changes Sep 9, 2020

View reviewed changes

Updated tests

01fd775

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 10, 2020

ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 10, 2020

amshuman-kr mentioned this pull request Oct 21, 2020

Added Scale subresource support #65

Closed

ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) needs/changes Needs (more) changes labels Nov 16, 2020

Fixed some corner cases and added test cases for the same

57a6e55

ghost added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2020

Added tests covering full round of scaling

3c61b65

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020

amshuman-kr mentioned this pull request May 12, 2021

Allow disabling scale-down of some control-plane components gardener/gardener#4030

Merged

ghost added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 19, 2021

amshuman-kr mentioned this pull request Jul 29, 2021

Keep kube-apiserver HPA scale down mode Auto even when scale down is disabled. gardener/gardener#4451

Merged

amshuman-kr mentioned this pull request Aug 31, 2021

[WIP] Implement HVPA v2 proposal #88

Open

ghost closed this Aug 31, 2021

ggaurav10 mentioned this pull request Oct 5, 2021

Update CRD to apiextensions.k8s.io/v1 #89

Merged

This pull request was closed.

	Entry("UpdateMode Auto, scale up, paradoxical scaling, replicas increases, resources per replica decreases", &data{
	Entry("UpdateMode Auto, scale up, paradoxical scaling, replicas increases, resources per replica decrease is blocked", &data{

	Entry("UpdateMode Auto, scale down hysteresis", &data{
	Entry("UpdateMode Auto, scale down hysteresis based on scaling intervals overlap", &data{

Uh oh!

Conversation

ggaurav10 commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amshuman-kr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amshuman-kr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amshuman-kr commented Aug 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ggaurav10 commented Aug 10, 2020 •

edited

Loading

CLAassistant commented Sep 16, 2020 •

edited

Loading