Fix home page layout broken on small screens#165
Open
kisaragi-hiu wants to merge 1 commit into
Open
Conversation
leftie/rightie: The max-width override was not taking effect as `[dir="ltr"] div.leftie` etc. have higher specificity (a media rule does not add specificity). div.welcome: Remove its minimum height on narrow screens where it is now displayed on top of the user section. div.usertop: Allow email to overflow and have its own scrollbar instead of making the whole page overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The home page layout is broken on narrow screens. This is because while the
leftieandrightieclasses have screen size rules that try to make them stacked vertically on narrow screens, these rules are not taking effect as they don't have enough specificity.This PR fixes that, as well as making the welcome element not demand a minimum height on narrow screens, and making the user email get its own scrollbar if necessary instead of overflowing the whole page.