Skip to content

Fix #248: Make analytics opt-in with migration for existing users #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jloutsch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #248: Make analytics opt-in with migration for existing users #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/containers/App/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,21 @@ class App extends Component {
const { actionCreateCopyJsonFileToSettings } = this.props;
const settingsFromStorage = settingsStorage.getAll();

// Migration: Change analytics to opt-in for all users (Issue #248)
// Previously analytics was opt-out by default, which is a privacy concern.
// This migration ensures all users (new and existing) have analytics disabled by default.
if (typeof settingsFromStorage.enableAnalytics === 'undefined') {
// New installation - use the new default (false) from initialState
settingsFromStorage.enableAnalytics = false;
} else if (settingsFromStorage.enableAnalytics === true) {
// Existing installation with analytics enabled - disable it for privacy
// Users can re-enable if they choose to opt-in
settingsFromStorage.enableAnalytics = false;

// Persist this change immediately
settingsStorage.setAll({ ...settingsFromStorage });
}

actionCreateCopyJsonFileToSettings({ ...settingsFromStorage });
} catch (e) {
log.error(e, `App -> writeJsonToSettings`);
Expand Down
2 changes: 1 addition & 1 deletion app/containers/Settings/reducers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const initialState = {
enableBackgroundAutoUpdate: true,
// if the freshly installed version is a prerelease version then save [enablePrereleaseUpdates] as true
enablePrereleaseUpdates: isPrereleaseVersion() || false,
enableAnalytics: true,
enableAnalytics: false,
enableStatusBar: true,
enableUsbHotplug: false,
hideHiddenFiles: {
Expand Down