remove cargokit in favor of native_toolchain_rust - #13
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Cargokit to Dart native assets for building and bundling the Rust library. It removes all Cargokit-related configuration files and scripts across all platforms, replacing them with a Dart build hook (hook/build.dart) that utilizes native_toolchain_rust. Feedback was provided regarding rust/rust-toolchain.toml, pointing out that the specified Rust version 1.90.0 is non-existent and will cause build failures, with a suggestion to use a valid stable version instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| [toolchain] | ||
| # WARNING: *do not* use `stable`, `beta`, or `nightly` (alone) for the channel! | ||
| # You must specify a version number/date in order to ensure reproducible builds. | ||
| channel = "1.90.0" # or newer. another example: `nightly-2025-01-01` |
There was a problem hiding this comment.
The Rust version 1.90.0 does not exist yet (the current stable version is around 1.84 / 1.85). Specifying a non-existent version in rust-toolchain.toml will cause rustup to fail immediately when building the project. Please use a valid, existing Rust version (e.g., 1.84.0 or 1.85.0).
| channel = "1.90.0" # or newer. another example: `nightly-2025-01-01` | |
| channel = "1.84.0" # or newer. another example: nightly-2025-01-01 |
Add smoke tests for Linux, Windows, macOS, iOS, and Android platforms in the CI pipeline, along with KVM setup for Android emulator support. Update the Dart format task to include the integration_test directory and reorder format dependencies to run flutter.fmt before rust.fmt.
These platforms are now handled entirely via Dart native assets (see hook/build.dart), so declaring them in pubspec triggers CocoaPods to compile an empty stub framework that shadows the native-assets-bundled dylib at runtime.
1 participant
No description provided.