Stop the 'see it in action' demo box from resizing mid-play#388
Merged
Conversation
The "see it in action" panes grew with their content (up to a max-height), so the box climbed as the transcript played and jumped when the final result bubble landed — visible across scenarios. Give the demo body a fixed height (430px, sized to the tallest scenario) and let the chat and notebook panes flex-fill and scroll internally instead. The box is now a constant size from the first frame, in every scenario; stacked/mobile mode uses fixed pane heights to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo panes grew with their content (up to a max-height), so the box climbed as the transcript played and jumped when the final "All 4 samples aligned…" result bubble appeared — visible across all three scenarios.
Fix: give the demo body a fixed height (430px, sized to the tallest scenario — RNA-seq) and let the chat and notebook panes flex-fill and scroll internally. The box is now a constant size from the first frame in every scenario (verified: 430px across variant / RNA-seq / QC). Stacked/mobile mode uses fixed pane heights to match. Build + typecheck clean.