Validate matched multi-input expansion errors before async job prep

[SID-6921]

Summary

• catch InputMatchedException in tool input expansion paths (expand_incoming and expand_incoming_async)
• convert these to RequestParameterInvalidException so malformed matched-input requests are surfaced as request validation errors instead of bubbling into async prep paths

Problem

Issue #22884 reports malformed matched inputs reaching async prep and generating noisy internal errors around Celery job preparation. This patch validates the error at API/tool expansion boundary and returns a clear request-level error.

Notes

• This change applies to both sync and async expansion paths for consistency.
• Related issue: Celery job prep, needs more validation, more context: InputMatchedException: Received 2 inputs for 'reference_genome|own_file' and 1 inputs for 'library|input_1', these should be of equal length #22884

Testing

• python -m py_compile lib/galaxy/tools/init.py
• Full unit tests are not runnable in this Windows environment because Galaxy's test stack imports POSIX-only pwd in conftest.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves request validation behavior by translating InputMatchedException failures from meta-parameter expansion into a user-facing RequestParameterInvalidException.

Changes:

• Import InputMatchedException for handling expansion failures.
• Wrap expand_meta_parameters_async(...) in try/except to raise RequestParameterInvalidException.
• Wrap expand_meta_parameters(...) in try/except to raise RequestParameterInvalidException.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mvdbeek]

This looks good but could you include a test for the API level behavior ?

galaxy/lib/galaxy_test/api/test_jobs.py

Lines 1354 to 1364 in 6b81c55

	with self.dataset_populator.test_history() as history_id:
	response = self.dataset_populator.tool_request_raw(
	tool_id="data_manager",
	inputs={"ignored_value": "test", "exit_code": 0},
	history_id=history_id,
	strict=False,
	)
	response.raise_for_status()
	tool_request_id = response.json()["tool_request_id"]
	submitted = self.dataset_populator.wait_on_tool_request(tool_request_id)
	assert submitted, self.dataset_populator.get_tool_request(tool_request_id)

is more or less how this could look like

[SID-6921]

Added the requested API-level regression test in 0995097. New test: test_async_job_submission_rejects_mismatched_multi_inputs in lib/galaxy_test/api/test_jobs.py. It verifies async POST /api/jobs returns 400 with a validation error when matched multi-input lengths differ.

[mvdbeek]

https://github.com/galaxyproject/galaxy/actions/runs/28682121263/job/85075326385?pr=23058#step:9:1060 is a relevant test failure

[SID-6921]

I've refactored the code to extract the duplicate InputMatchedException handling into a helper method _raise_matched_input_errors. This consolidates the logic between \�xpand_incoming_async\ and \�xpand_incoming, improving maintainability and ensuring consistent error handling.

Changes made:

• Added helper method to convert InputMatchedException to RequestParameterInvalidException
• Updated both API paths (sync and async) to use the helper
• This ensures mismatched multi-input parameter lengths surface as 400 validation errors

The refactored code maintains the same behavior while reducing duplication. Tests are running now.

[mvdbeek]

The same test is still failing: https://github.com/galaxyproject/galaxy/actions/runs/29383806554/job/87287064090?pr=23058#step:7:1636