Skip to content

Scottcain add run centerpanel#23037

Draft
scottcain wants to merge 3 commits into
galaxyproject:devfrom
scottcain:scottcain-add-run-centerpanel
Draft

Scottcain add run centerpanel#23037
scottcain wants to merge 3 commits into
galaxyproject:devfrom
scottcain:scottcain-add-run-centerpanel

Conversation

@scottcain

Copy link
Copy Markdown
Contributor

This is a first effort add generalizing the use of the post-run job webhook that eu uses for their site so that any instance can make use of it, as mentioned in #23036

Did I vibe code it? Yes. Do the changes seem pretty minimal and straightforward? Also yes.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:

I also ran Galaxy locally to test that what I expected to happen did after pressing the "run job" button.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@scottcain

Copy link
Copy Markdown
Contributor Author

In addition to this fairly simple change, I'd like to add the ability to have the contents of the iframe be picked from a weighted list like EU does it too, though I'm unsure which way to do that would be most acceptable. I believe EU uses a modified __init__.py to do the math to decide what gets returned, meaning anybody who wanted to do the same would have to provide their own __init__.py.

Alternatively, (and this feels more right to me), I'd suggest modify __init__.py to allow the config file to specify a collection of urls and weights and __init__.py would use that to do the math and return a result. It makes __init__.py more complicated but makes it easier on implementers.

@jmchilton

Copy link
Copy Markdown
Member

Did you find the EU implementation and copy it over or vibe code it from scratch? I think we should make sure we're reducing the lines of diff of .EU not give them merging technical debt.

@bgruening

Copy link
Copy Markdown
Member

Our stuff is here: https://github.com/usegalaxy-eu/galaxy-webhooks

I don't remember anymore but I think we have been recommended to maintain them outside of the Galaxy source.

@scottcain

Copy link
Copy Markdown
Contributor Author

I pointed out the webhooks repo to claude and let it manage the migration, so I strongly suspect it's mostly a copy and paste job. @bgruening mentioned that suggestion when we talked about it some time ago (>1 year) but I'd like to see if there is a way we can make this generically available.

----------------------------

Galaxy ships with an ``iframe`` webhook (``config/plugins/webhooks/iframe/``) that displays a configurable web page
in a panel below the standard job-submission confirmation message after a user runs a tool or workflow.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather we don't do that and redirect the user directly to the job (or implicit job collection) info page ? It seems like for this particular usecase were better off keeping this external ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdbeek I'm not sure I understand your comment. The user gets redirected to the job info page. This webhook adds something under the green box, like this:

Image

@mvdbeek mvdbeek Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the job info page, you get to the job info page by by clicking on "Here is the link to the Job". We should just do that and remove the /success route. We never had a job info page when the success page was added and staying on the tool form had users submit jobs multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

4 participants