Type annotations and refactorings#21673
Merged
Merged
Conversation
…th_metadata_options_filter`` API tests Duplicates of `lib/galaxy_test/api/test_tool_execute.py::test_deferred_basic` and ``lib/galaxy_test/api/test_tool_execute.py::test_deferred_with_metadata_options_filter`` respectively.
jmchilton
reviewed
Jan 27, 2026
|
|
||
| @property | ||
| def execute(self) -> "DescribeToolExecution": | ||
| execution = DescribeToolExecution(self._dataset_populator, self._tool_id) |
Member
There was a problem hiding this comment.
Not entirely uncontroversial. I loved how the old call lines were so optimized and legible. I'd rather have a property execute_with_job_cache to match execute. I'll admit a property that changes state is a Python anti-pattern though.
Member
Author
There was a problem hiding this comment.
Thanks for reviewing! I don't feel having to add () makes it less legible, but I do agree on the second part :)
jmchilton
approved these changes
Jan 27, 2026
|
This PR was merged without a "kind/" label, please correct. |
nsoranzo
added
kind/enhancement
kind/refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the uncontroversial changes from #19112 .
How to test the changes?
(Select all options that apply)
License