Repository navigation
Conversation
Author
|
The CI run is awaiting approval ( Please also assign this PR to v0.2.0 The gates hold, matching #105, before merge as required by the project's contribution workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When statistics rows stop matching the supported
<tr id="...">shape, the reader currently reportsErrNoFiguresandAccountsskips the HTML account. Return a report-reader error when either statistics table contains unrecognised data rows, while retainingErrNoFiguresfor genuinely empty tables such as the recorded Gatling 3.13.1 report.The regression changes every data-row opening, including ROOT, in a temporary copy of the recorded 3.15.1 report and checks both error classification and
Accountspropagation. It also covers table boundaries, headings and direct table rows. The change uses the existing table boundaries and standard-library regular expressions.Closes #105. Specification: 012-report-reader-row-shape.
Validation with Go 1.27.2: focused regressions, core race/shuffle tests, recorded-corpus integration (349 cases), build, vet, module checks, workflow pins and six shell suites passed. Coverage floors passed at 93.6% overall (84.0% for
internal/corpus).Local lint/format checks with golangci-lint 2.14.0 remain nonzero: the same five lint findings and four formatting hunks reproduce on the unchanged base, with no additional findings from this change. The configured Go 1.26.8 download timed out; that toolchain, minimum Go 1.25 and CI's lint 2.12.2 were not verified locally. Hosted CI still needs to cover the pinned vulnerability, NFR and API-compatibility checks, fresh Gatling canary, separate peak-memory test and PR fuzz budget before merge.