Repository navigation
fix(packaging): stop shipping a test suite the sdist cannot run - #87
Merged
Merged
Conversation
The sdist included tests/ but excluded .github/, docs/, scripts/ and dagger.json, all of which those tests read. Running pytest from the extracted archive therefore failed on missing fixtures. Ship distribution sources only; the test suite remains in the repository and in CI.
hseshadr
force-pushed
the
fix/lean-sdist
branch
from
October 24, 2026 21:14
91f55c0 to
a83a01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
[tool.hatch.build.targets.sdist]shippedtests/, but the suite reads.github/,docs/,scripts/anddagger.json, all of which the sdist excludes. Runningpytestfrom the extracted archive therefore failed on missing fixtures — the archive could not run the tests it carried.The sdist now carries distribution sources only (
edgeproc_core,examples, README/CHANGELOG/LICENSE/SECURITY/CONTRIBUTING). Tests stay in the repository and in CI.Tests
pytest -q: 382 passed, 99.1% coverage.python -m build --sdistand a listing of the archive to confirmtests/is absent (not run here; the packaging change is declarative).Alternative considered
Shipping the missing
.github/,docs/,scripts/anddagger.jsonwould make the suite runnable from the archive, but puts CI metadata and docs in the distribution tarball. Dropping the tests is the leaner contract; distro packagers who want tests can use the repository.