Repository navigation
fix(ci): make the lint gate read-only - #88
Merged
Merged
Conversation
`poe lint` ran `ruff check --fix` and `ruff format` in place, so the hosted gate could rewrite a dirty tree and still exit 0. It now runs `ruff check` and `ruff format --check`, matching the three module gates: a formatting regression fails instead of being silently repaired inside the container. Tests: uv run poe lint.
The control plane reads cross-repo state and writes packages but had no SECURITY.md. Document the private channel and the in-scope bypasses: source guard, secret scan, fleet evidence, and workflow injection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
poe lintranruff check --fixandruff formatin place, sodagger call cicould rewrite a dirty tree and still exit 0. It now runsruff checkandruff format --check, matching the three module gates (portfolio-foundation,cloudflare-pages,python-package).A formatting or auto-fixable lint regression now fails the hosted gate instead of being silently repaired inside the container.
Tests
uv run poe lint: clean on this tree.Note
gatestill runslintfirst, so a developer who wants the old convenience can runuv run poe lint --fixlocally; the hosted gate is the one that must be read-only.