Repository navigation
fix(demo): print the page address when no browser opens; README prerequisites and first-run time - #42
Merged
Merged
Conversation
On a server or in a container, webbrowser.open finds no browser and returns False; make demo then said only "Demo running at ..." and left the reader waiting for a browser that never came. It now also says "No browser could be opened here. Open <url> in a browser." --no-browser stays quiet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GRdR6TpVeKiz2Tr4hEGsEo
…e no-browser case Checked on a clean debian:bookworm-slim container: uv's installer needs curl, and git clone plus the uv download need ca-certificates. The first make demo was ready in 6 s on a fast link (Python + 112 packages). With no browser, make demo now prints the address to open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GRdR6TpVeKiz2Tr4hEGsEo
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GRdR6TpVeKiz2Tr4hEGsEo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open items left after #41.
Claim touched: the README's "Try it" promise: clone,
make demo, and you see the page. No privacy or data claim is touched.What changed
make demoon a machine with no browser (server, container) said only "Demo running at ..." becausewebbrowser.openreturned False silently. It now also printsNo browser could be opened here. Open http://127.0.0.1:8090/demo/ in a browser.--no-browserstays quiet.curl; a bare Linux image also needsca-certificates. The first-run time is now stated as measured (seconds on a fast link, a minute or two on a slow one). It also says what happens with no browser.Evidence
demo/cli.py100%poe lint(ruff, mypy --strict, xenon A)... is Nonefailstest_should_print_the_address_to_open_when_no_browser_can_be_openedmake demoready in 5.8 s including the cpython 3.13.16 download and 112 packages; quickstart output matches the README byte for bytemake demofrom a fresh clonedocs/assets/demo.png, so the image is left alone🤖 Generated with Claude Code
https://claude.ai/code/session_01GRdR6TpVeKiz2Tr4hEGsEo