Fixes needed to use latest compiler on Frontier#490
Merged
Conversation
* Use has_device_addr insted of has_device_ptr * Add OMPGPU_DEVICE_ADDR switch to use use_device_add instead of use_device_ptr in OMPGPU
* Replace ccl_del_device macro with explicit conditional pragmas * Replace pre-processor macros with full explansion - Some compilers do not like the multi-line macros containing pragmas * [FRONTIER] Switch to cpe/26.03 and enable OMPGPU_DEVICE_ADDR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler and ROCm version we relied on Frontier is deprecated, so we must move to a newer version.
A few changes were needed to have CGYRO compiled with the newer compilers.
Code changes are a no-op for the other platforms.