Fix API usage for sonar 7.7

[jblamotte]

Fix sonar-gitlab-plugin for sonar 7.7 with the new API.
(only tested with publish mode & quality gate on sonar developer edition)

[unitysipu]

@jblamotte for convenience, do you happen to have a pre-compiled plugin available you could share for this fix? Thanks!

[jblamotte]

You can find it here :
https://github.com/jblamotte/sonar-gitlab-plugin/releases/tag/4.1.0-SNAPSHOT
Just a snapshot, as Gabriel will probably merge it.
(or just git clone repo && git checkout feature-request && mvn clean install && cp the-jar.jar)

[unitysipu]

Thank you,

I'm slightly concerned about the future of this plugin and merges based on what @gabrie-allaigre mentioned here #222

I hope the community is able to pick up the effort from him.

[gabrie-allaigre]

Hi,
Thanks.
It's version work only with sonarqube 7.7 ?

[jblamotte]

Only tested on 7.7 on my side.

[unitysipu]

With preliminary testing It looks like the PR decorations (the untested preview mode) doesn't work with this change, which means some more work is needed. I will doublecheck on my side.

[unitysipu]

Ok, based on this https://docs.sonarqube.org/latest/setup/upgrade-notes/ it seems sonarsource has finally deprecated the sonar.analysis.mode switch on 7.7, so now builds fail

"14:42:43.337 INFO: ------------------------------------------------------------------------
14:42:43.337 ERROR: Error during SonarQube Scanner execution
14:42:43.338 ERROR: The preview mode, along with the 'sonar.analysis.mode' parameter, is no more supported. You should stop using this parameter."

Without this parameter the scan appears to work. Is there some alternate way to trigger PR analysis or is it game over for that feature?

Also this means that the issue is not the plugin changes in this PR.

[jblamotte]

It looks like it's game over for preview mode....
It's indeed a convenient way, to use sonar community edition for feature team with gitflow. (We were using it like that until we need a real quality gate).

[unitysipu]

Do you know if the decoration parameters that the commercial Sonarqube github PR decorations use are in any way compatible with gitlab plugin? (i.e. are those server features or plugin specific)?

[andrzejwp]

Hi @jblamotte, is there anything I could do to help with moving this forward?

[dmpe]

Bump

[nikolaikopernik]

Up. Any chances to get it worked?

[unitysipu]

#253 <- i think this supersedes this pull request. 100% working on 7.9.1.