Skip to content

Improve get command arguments validation #12

Open

Description

@qzb

Currently get command validates its parameters rather loosely. We should add at least following checks:

  • check if number of positional arguments is less than 2
  • validate command name and --alias against regexp (/^[a-z0-9_-]+$/?`)
  • check if --version is a correct semver range
  • check if --from is a correct URL

Activity

  1. added
    enhancementNew feature or request
    help wantedExtra attention is needed
    and removed
    help wantedExtra attention is needed
    on Nov 18, 2020
  2. linked a pull request that will close this issueDiscovery refactor #41on Jan 7, 2022
  3. crazybarber commented on Jan 7, 2022

    @crazybarber
    Contributor

    First bullet point is resolved by #41

  4. self-assigned this
    on Jun 15, 2022
  5. linked a pull request that will close this issuefeat: check if --from is a correct URL #67on Jul 5, 2023
  6. linked a pull request that will close this issuefix: missing argument length check #68on Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions