Repository navigation
feat(auth): lay the phone lock screen out in three bands - #575
Merged
Merged
Conversation
The compact lock screen stacked everything in one centred column: the mascot took the centre of the screen, and the Face ID tile and a bordered 52px "Enter Master Password" button competed under it as two offers of the same weight. It now lays the same parts out over the whole ground (AuthShell fill): the brand and the vault chip under the safe area; the status line and the biometric tile — or the card — at the exact centre of the screen, between two equal bands; and the passphrase as a plain 44px text control by the footer, the backup it is. The ground is sized to the visual viewport, so the keyboard the card brings up shortens it rather than covering the card. Compact only: the wide lock screen passes neither new prop and is unchanged.
Contributor
|
With the keyboard up a band cannot shrink under its content, so the 96px masthead held the top band open and pushed the card below the centre of what was left. The mascot steps down to 64px, and the masthead's gap to 20px, while the card is up; a screen too short for even that scrolls rather than clips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The phone lock screen stacked everything in one centred column: the mascot took the centre of the screen, and the Face ID tile and a bordered 52px "Enter Master Password" button competed below it as two offers of the same weight. This lays the same parts out by purpose, in three bands over the whole ground.
grid-rows-[1fr_auto_1fr]), so it sits at the exact centre of the screen, not merely in what the masthead leaves over.viewportStyle, as the compact shell already is), so the keyboard the card brings up shortens the screen under the card rather than covering it.AuthShellgains two opt-in props,fillandstyle, defaulting to its old behaviour.Compact only. The wide lock screen (
Auth) passes neither prop and renders as before. Its centred block with the card leading is the right layout where a keyboard is the primary input, so nothing here was carried over.Verification
bun run typecheck,bun run lint(0 warnings),bun run build: cleanbun run test: 1072 passedDecisions