Repository navigation
feat(compact): one header-action tier, tags in the search field, tighter list header - #574
Merged
Merged
Conversation
…ter list header Every icon action in a phone header corner — sort, regenerate, the sync chip, the entry's menu and star — now sits on one tier (HEADER_ACTION): a 44px target over a 20px glyph with no box of its own, the nav bar's proportion. Sort drew 16px and the menu 14px in the same target, and regenerate was the one bordered tile, which made it look twice the size of its neighbours. The list root keeps sort alone in the title row, as on the desktop, and sets the tag filter into the end of the search field (FIELD_ACTION: a 36px tile whose hit area is the field's full 44px) beside the query it narrows the list with. The field lights on the input's own focus rather than any focus within it, so pressing the tile or the clear button is not searching; the clear button gets a 44px target under a finger. The title row to the field is 8px instead of 16, and the field's run-out before the first row 4px instead of 10, so the list starts higher.
Contributor
|
The touch tier for the clear button was keyed on the pointer alone, so a wide layout under a finger (an iPad) put a 44px button in its 32px field. It is now the compact field's only, on the same 768px cut the field itself is chosen on.
alchaplinsky
added this pull request to stack #580
October 11, 2026 00:30
…ctions # Conflicts: # src/components/Main/Compact/Detail/Read.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up the swipe-back PR (#573) with the list root's header and the size of header actions across the phone screens. Independent of #573; based on
main.HEADER_ACTIONinchrome.ts: a 44px target over a 20px glyph with no box of its own — the nav bar's proportion on iOS (22pt in 44) and Android (24dp in 48). Applied to sort, regenerate, the sync chip, and the entry's menu and star. Sort drew a 16px glyph and the menu a 14px one in the same 44px target; regenerate was the only bordered tile, which is why it looked twice the size of its neighbours. The glyph is sized by the button, so shared desktop controls need no size prop.FIELD_ACTION: a 36px tile inset 4px, with the field's full 44px as its hit area via a pseudo-element), its own control beside the query it narrows the list with. Its menu drops below the field.SearchBoxkeyed its lit state on:focus-within, which the tag tile and the clear button would now trigger; it is:has(input:focus)instead. The clear button gets a 44px target on coarse pointers.Verification
bun run typecheck,bun run lint(0 warnings),bun run build: cleanbun run test: 1073 passedDecisions